Coverage Report

Created: 2026-04-09 13:35

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
be/src/service/http/action/compaction_action.cpp
Line
Count
Source
1
// Licensed to the Apache Software Foundation (ASF) under one
2
// or more contributor license agreements.  See the NOTICE file
3
// distributed with this work for additional information
4
// regarding copyright ownership.  The ASF licenses this file
5
// to you under the Apache License, Version 2.0 (the
6
// "License"); you may not use this file except in compliance
7
// with the License.  You may obtain a copy of the License at
8
//
9
//   http://www.apache.org/licenses/LICENSE-2.0
10
//
11
// Unless required by applicable law or agreed to in writing,
12
// software distributed under the License is distributed on an
13
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
14
// KIND, either express or implied.  See the License for the
15
// specific language governing permissions and limitations
16
// under the License.
17
18
#include "service/http/action/compaction_action.h"
19
20
// IWYU pragma: no_include <bits/chrono.h>
21
#include <chrono> // IWYU pragma: keep
22
#include <exception>
23
#include <future>
24
#include <memory>
25
#include <mutex>
26
#include <sstream>
27
#include <string>
28
#include <thread>
29
#include <utility>
30
31
#include "absl/strings/substitute.h"
32
#include "common/logging.h"
33
#include "common/metrics/doris_metrics.h"
34
#include "common/status.h"
35
#include "service/http/http_channel.h"
36
#include "service/http/http_headers.h"
37
#include "service/http/http_request.h"
38
#include "service/http/http_status.h"
39
#include "storage/compaction/base_compaction.h"
40
#include "storage/compaction/cumulative_compaction.h"
41
#include "storage/compaction/cumulative_compaction_policy.h"
42
#include "storage/compaction/cumulative_compaction_time_series_policy.h"
43
#include "storage/compaction/full_compaction.h"
44
#include "storage/compaction/single_replica_compaction.h"
45
#include "storage/compaction_task_tracker.h"
46
#include "storage/olap_define.h"
47
#include "storage/storage_engine.h"
48
#include "storage/tablet/tablet_manager.h"
49
#include "util/stopwatch.hpp"
50
51
namespace doris {
52
using namespace ErrorCode;
53
54
namespace {
55
56
constexpr std::string_view HEADER_JSON = "application/json";
57
58
} // namespace
59
60
CompactionAction::CompactionAction(CompactionActionType ctype, ExecEnv* exec_env,
61
                                   StorageEngine& engine, TPrivilegeHier::type hier,
62
                                   TPrivilegeType::type ptype)
63
15
        : HttpHandlerWithAuth(exec_env, hier, ptype), _engine(engine), _compaction_type(ctype) {}
64
65
/// check param and fetch tablet_id & table_id from req
66
0
static Status _check_param(HttpRequest* req, uint64_t* tablet_id, uint64_t* table_id) {
67
    // req tablet id and table id, we have to set only one of them.
68
0
    const auto& req_tablet_id = req->param(TABLET_ID_KEY);
69
0
    const auto& req_table_id = req->param(TABLE_ID_KEY);
70
0
    if (req_tablet_id.empty()) {
71
0
        if (req_table_id.empty()) {
72
            // both tablet id and table id are empty, return error.
73
0
            return Status::InternalError(
74
0
                    "tablet id and table id can not be empty at the same time!");
75
0
        } else {
76
0
            try {
77
0
                *table_id = std::stoull(req_table_id);
78
0
            } catch (const std::exception& e) {
79
0
                return Status::InternalError("convert table_id failed, {}", e.what());
80
0
            }
81
0
            return Status::OK();
82
0
        }
83
0
    } else if (req_table_id.empty()) {
84
0
        try {
85
0
            *tablet_id = std::stoull(req_tablet_id);
86
0
        } catch (const std::exception& e) {
87
0
            return Status::InternalError("convert tablet_id failed, {}", e.what());
88
0
        }
89
0
        return Status::OK();
90
0
    } else {
91
        // both tablet id and table id are not empty, return err.
92
0
        return Status::InternalError("tablet id and table id can not be set at the same time!");
93
0
    }
94
0
}
95
96
/// retrieve specific id from req
97
0
static Status _check_param(HttpRequest* req, uint64_t* id_param, const std::string param_name) {
98
0
    const auto& req_id_param = req->param(param_name);
99
0
    if (!req_id_param.empty()) {
100
0
        try {
101
0
            *id_param = std::stoull(req_id_param);
102
0
        } catch (const std::exception& e) {
103
0
            return Status::InternalError("convert {} failed, {}", param_name, e.what());
104
0
        }
105
0
    }
106
107
0
    return Status::OK();
108
0
}
109
110
// for viewing the compaction status
111
0
Status CompactionAction::_handle_show_compaction(HttpRequest* req, std::string* json_result) {
112
0
    uint64_t tablet_id = 0;
113
    // check & retrieve tablet_id from req if it contains
114
0
    RETURN_NOT_OK_STATUS_WITH_WARN(_check_param(req, &tablet_id, TABLET_ID_KEY),
115
0
                                   "check param failed");
116
0
    if (tablet_id == 0) {
117
0
        return Status::InternalError("check param failed: missing tablet_id");
118
0
    }
119
120
0
    TabletSharedPtr tablet = _engine.tablet_manager()->get_tablet(tablet_id);
121
0
    if (tablet == nullptr) {
122
0
        return Status::NotFound("Tablet not found. tablet_id={}", tablet_id);
123
0
    }
124
125
0
    tablet->get_compaction_status(json_result);
126
0
    return Status::OK();
127
0
}
128
129
0
Status CompactionAction::_handle_run_compaction(HttpRequest* req, std::string* json_result) {
130
    // 1. param check
131
    // check req_tablet_id or req_table_id is not empty and can not be set together.
132
0
    uint64_t tablet_id = 0;
133
0
    uint64_t table_id = 0;
134
0
    RETURN_NOT_OK_STATUS_WITH_WARN(_check_param(req, &tablet_id, &table_id), "check param failed");
135
136
    // check compaction_type equals 'base' or 'cumulative'
137
0
    std::string compaction_type = req->param(PARAM_COMPACTION_TYPE);
138
0
    if (compaction_type != PARAM_COMPACTION_BASE &&
139
0
        compaction_type != PARAM_COMPACTION_CUMULATIVE &&
140
0
        compaction_type != PARAM_COMPACTION_FULL) {
141
0
        return Status::NotSupported("The compaction type '{}' is not supported", compaction_type);
142
0
    }
143
144
    // "remote" = "true" means tablet should do single replica compaction to fetch rowset from peer
145
0
    bool fetch_from_remote = false;
146
0
    std::string param_remote = req->param(PARAM_COMPACTION_REMOTE);
147
0
    if (param_remote == "true") {
148
0
        fetch_from_remote = true;
149
0
    } else if (!param_remote.empty() && param_remote != "false") {
150
0
        return Status::NotSupported("The remote = '{}' is not supported", param_remote);
151
0
    }
152
153
0
    if (tablet_id == 0 && table_id != 0) {
154
0
        std::vector<TabletSharedPtr> tablet_vec = _engine.tablet_manager()->get_all_tablet(
155
0
                [table_id](Tablet* tablet) -> bool { return tablet->get_table_id() == table_id; });
156
0
        for (const auto& tablet : tablet_vec) {
157
0
            tablet->set_last_full_compaction_schedule_time(UnixMillis());
158
0
            RETURN_IF_ERROR(_engine.submit_compaction_task(tablet, CompactionType::FULL_COMPACTION,
159
0
                                                           false, true, 1));
160
0
        }
161
0
    } else {
162
        // 2. fetch the tablet by tablet_id
163
0
        TabletSharedPtr tablet = _engine.tablet_manager()->get_tablet(tablet_id);
164
0
        if (tablet == nullptr) {
165
0
            return Status::NotFound("Tablet not found. tablet_id={}", tablet_id);
166
0
        }
167
168
0
        if (fetch_from_remote && !tablet->should_fetch_from_peer()) {
169
0
            return Status::NotSupported("tablet should do compaction locally");
170
0
        }
171
0
        DBUG_EXECUTE_IF("CompactionAction._handle_run_compaction.submit_cumu_task", {
172
0
            RETURN_IF_ERROR(_engine.submit_compaction_task(
173
0
                    tablet, CompactionType::CUMULATIVE_COMPACTION, false));
174
0
            LOG(INFO) << "Manual debug compaction task is successfully triggered";
175
0
            *json_result =
176
0
                    R"({"status": "Success", "msg": "debug compaction task is successfully triggered. Table id: )" +
177
0
                    std::to_string(table_id) + ". Tablet id: " + std::to_string(tablet_id) + "\"}";
178
0
            return Status::OK();
179
0
        })
180
181
        // 3. execute compaction task
182
0
        std::packaged_task<Status()> task([this, tablet, compaction_type, fetch_from_remote]() {
183
0
            return _execute_compaction_callback(tablet, compaction_type, fetch_from_remote);
184
0
        });
185
0
        std::future<Status> future_obj = task.get_future();
186
0
        std::thread(std::move(task)).detach();
187
188
        // 更新schedule_time
189
0
        if (compaction_type == PARAM_COMPACTION_BASE) {
190
0
            tablet->set_last_base_compaction_schedule_time(UnixMillis());
191
0
        } else if (compaction_type == PARAM_COMPACTION_CUMULATIVE) {
192
0
            tablet->set_last_cumu_compaction_schedule_time(UnixMillis());
193
0
        } else if (compaction_type == PARAM_COMPACTION_FULL) {
194
0
            tablet->set_last_full_compaction_schedule_time(UnixMillis());
195
0
        }
196
197
        // 4. wait for result for 2 seconds by async
198
0
        std::future_status status = future_obj.wait_for(std::chrono::seconds(2));
199
0
        if (status == std::future_status::ready) {
200
            // fetch execute result
201
0
            Status olap_status = future_obj.get();
202
0
            if (!olap_status.ok()) {
203
0
                return olap_status;
204
0
            }
205
0
        } else {
206
0
            LOG(INFO) << "Manual compaction task is timeout for waiting "
207
0
                      << (status == std::future_status::timeout);
208
0
        }
209
0
    }
210
0
    LOG(INFO) << "Manual compaction task is successfully triggered";
211
0
    *json_result =
212
0
            R"({"status": "Success", "msg": "compaction task is successfully triggered. Table id: )" +
213
0
            std::to_string(table_id) + ". Tablet id: " + std::to_string(tablet_id) + "\"}";
214
0
    return Status::OK();
215
0
}
216
217
0
Status CompactionAction::_handle_run_status_compaction(HttpRequest* req, std::string* json_result) {
218
0
    uint64_t tablet_id = 0;
219
    // check & retrieve tablet_id from req if it contains
220
0
    RETURN_NOT_OK_STATUS_WITH_WARN(_check_param(req, &tablet_id, TABLET_ID_KEY),
221
0
                                   "check param failed");
222
223
0
    if (tablet_id == 0) {
224
        // overall compaction status
225
0
        _engine.get_compaction_status_json(json_result);
226
0
        return Status::OK();
227
0
    } else {
228
        // fetch the tablet by tablet_id
229
0
        TabletSharedPtr tablet = _engine.tablet_manager()->get_tablet(tablet_id);
230
0
        if (tablet == nullptr) {
231
0
            LOG(WARNING) << "invalid argument.tablet_id:" << tablet_id;
232
0
            return Status::InternalError("fail to get {}", tablet_id);
233
0
        }
234
235
0
        std::string json_template = R"({
236
0
            "status" : "Success",
237
0
            "run_status" : $0,
238
0
            "msg" : "$1",
239
0
            "tablet_id" : $2,
240
0
            "compact_type" : "$3"
241
0
        })";
242
243
0
        std::string msg = "compaction task for this tablet is not running";
244
0
        std::string compaction_type;
245
0
        bool run_status = false;
246
247
0
        {
248
            // Full compaction holds both base compaction lock and cumu compaction lock.
249
            // So we can not judge if full compaction is running by check these two locks holding.
250
            // Here, we use a variable 'is_full_compaction_running' to check if full compaction is running.
251
0
            if (tablet->is_full_compaction_running()) {
252
0
                msg = "compaction task for this tablet is running";
253
0
                compaction_type = "full";
254
0
                run_status = true;
255
0
                *json_result = absl::Substitute(json_template, run_status, msg, tablet_id,
256
0
                                                compaction_type);
257
0
                return Status::OK();
258
0
            }
259
0
        }
260
261
0
        {
262
            // use try lock to check this tablet is running cumulative compaction
263
0
            std::unique_lock<std::mutex> lock_cumulative(tablet->get_cumulative_compaction_lock(),
264
0
                                                         std::try_to_lock);
265
0
            if (!lock_cumulative.owns_lock()) {
266
0
                msg = "compaction task for this tablet is running";
267
0
                compaction_type = "cumulative";
268
0
                run_status = true;
269
0
                *json_result = absl::Substitute(json_template, run_status, msg, tablet_id,
270
0
                                                compaction_type);
271
0
                return Status::OK();
272
0
            }
273
0
        }
274
275
0
        {
276
            // use try lock to check this tablet is running base compaction
277
0
            std::unique_lock<std::mutex> lock_base(tablet->get_base_compaction_lock(),
278
0
                                                   std::try_to_lock);
279
0
            if (!lock_base.owns_lock()) {
280
0
                msg = "compaction task for this tablet is running";
281
0
                compaction_type = "base";
282
0
                run_status = true;
283
0
                *json_result = absl::Substitute(json_template, run_status, msg, tablet_id,
284
0
                                                compaction_type);
285
0
                return Status::OK();
286
0
            }
287
0
        }
288
        // not running any compaction
289
0
        *json_result = absl::Substitute(json_template, run_status, msg, tablet_id, compaction_type);
290
0
        return Status::OK();
291
0
    }
292
0
}
293
294
Status CompactionAction::_execute_compaction_callback(TabletSharedPtr tablet,
295
                                                      const std::string& compaction_type,
296
0
                                                      bool fetch_from_remote) {
297
0
    MonotonicStopWatch timer;
298
0
    timer.start();
299
300
0
    std::shared_ptr<CumulativeCompactionPolicy> cumulative_compaction_policy =
301
0
            CumulativeCompactionPolicyFactory::create_cumulative_compaction_policy(
302
0
                    tablet->tablet_meta()->compaction_policy());
303
0
    if (tablet->get_cumulative_compaction_policy() == nullptr) {
304
0
        tablet->set_cumulative_compaction_policy(cumulative_compaction_policy);
305
0
    }
306
0
    Status res = Status::OK();
307
0
    auto* tracker = CompactionTaskTracker::instance();
308
0
    auto do_compact = [&](Compaction& compaction, CompactionProfileType profile_type) {
309
0
        RETURN_IF_ERROR(compaction.prepare_compact());
310
        // Register task as RUNNING with tracker (manual trigger, direct execution path)
311
        // Use compaction.compaction_id() which was allocated in constructor.
312
0
        int64_t compaction_id = compaction.compaction_id();
313
0
        {
314
0
            CompactionTaskInfo info;
315
0
            info.compaction_id = compaction_id;
316
0
            info.tablet_id = tablet->tablet_id();
317
0
            info.table_id = tablet->get_table_id();
318
0
            info.partition_id = tablet->partition_id();
319
0
            info.compaction_type = profile_type;
320
0
            info.status = CompactionTaskStatus::RUNNING;
321
0
            info.trigger_method = TriggerMethod::MANUAL;
322
0
            auto now_ms = std::chrono::duration_cast<std::chrono::milliseconds>(
323
0
                                  std::chrono::system_clock::now().time_since_epoch())
324
0
                                  .count();
325
0
            info.scheduled_time_ms = now_ms;
326
0
            info.start_time_ms = now_ms;
327
0
            info.compaction_score = tablet->get_real_compaction_score();
328
0
            info.input_rowsets_count = compaction.input_rowsets_count();
329
0
            info.input_row_num = compaction.input_row_num_value();
330
0
            info.input_data_size = compaction.input_rowsets_data_size();
331
0
            info.input_index_size = compaction.input_rowsets_index_size();
332
0
            info.input_total_size = compaction.input_rowsets_total_size();
333
0
            info.input_segments_num = compaction.input_segments_num_value();
334
0
            info.input_version_range = compaction.input_version_range_str();
335
0
            info.is_vertical = compaction.is_vertical();
336
0
            info.backend_id = BackendOptions::get_backend_id();
337
0
            tracker->register_task(std::move(info));
338
0
        }
339
0
        auto st = compaction.execute_compact();
340
        // Idempotent cleanup: if execute returned early (e.g. TRY_LOCK_FAILED)
341
        // before submit_profile_record was called, task remains in active_tasks.
342
0
        tracker->remove_task(compaction_id);
343
0
        return st;
344
0
    };
345
0
    if (compaction_type == PARAM_COMPACTION_BASE) {
346
0
        BaseCompaction base_compaction(_engine, tablet);
347
0
        res = do_compact(base_compaction, CompactionProfileType::BASE);
348
0
        if (!res) {
349
0
            if (!res.is<BE_NO_SUITABLE_VERSION>()) {
350
0
                DorisMetrics::instance()->base_compaction_request_failed->increment(1);
351
0
            }
352
0
        }
353
0
    } else if (compaction_type == PARAM_COMPACTION_CUMULATIVE) {
354
0
        if (fetch_from_remote) {
355
0
            SingleReplicaCompaction single_compaction(_engine, tablet,
356
0
                                                      CompactionType::CUMULATIVE_COMPACTION);
357
0
            res = do_compact(single_compaction, CompactionProfileType::CUMULATIVE);
358
0
            if (!res) {
359
0
                LOG(WARNING) << "failed to do single compaction. res=" << res
360
0
                             << ", table=" << tablet->tablet_id();
361
0
            }
362
0
        } else {
363
0
            CumulativeCompaction cumulative_compaction(_engine, tablet);
364
0
            res = do_compact(cumulative_compaction, CompactionProfileType::CUMULATIVE);
365
0
            if (!res) {
366
0
                if (res.is<CUMULATIVE_NO_SUITABLE_VERSION>()) {
367
                    // Ignore this error code.
368
0
                    VLOG_NOTICE
369
0
                            << "failed to init cumulative compaction due to no suitable version,"
370
0
                            << "tablet=" << tablet->tablet_id();
371
0
                } else {
372
0
                    DorisMetrics::instance()->cumulative_compaction_request_failed->increment(1);
373
0
                    LOG(WARNING) << "failed to do cumulative compaction. res=" << res
374
0
                                 << ", table=" << tablet->tablet_id();
375
0
                }
376
0
            }
377
0
        }
378
0
    } else if (compaction_type == PARAM_COMPACTION_FULL) {
379
0
        FullCompaction full_compaction(_engine, tablet);
380
0
        res = do_compact(full_compaction, CompactionProfileType::FULL);
381
0
        if (!res) {
382
0
            if (res.is<FULL_NO_SUITABLE_VERSION>()) {
383
                // Ignore this error code.
384
0
                VLOG_NOTICE << "failed to init full compaction due to no suitable version,"
385
0
                            << "tablet=" << tablet->tablet_id();
386
0
            } else {
387
0
                LOG(WARNING) << "failed to do full compaction. res=" << res
388
0
                             << ", table=" << tablet->tablet_id();
389
0
            }
390
0
        }
391
0
    }
392
0
    timer.stop();
393
0
    LOG(INFO) << "Manual compaction task finish, status=" << res
394
0
              << ", compaction_use_time=" << timer.elapsed_time() / 1000000 << "ms";
395
0
    return res;
396
0
}
397
398
0
void CompactionAction::handle(HttpRequest* req) {
399
0
    req->add_output_header(HttpHeaders::CONTENT_TYPE, HEADER_JSON.data());
400
401
0
    if (_compaction_type == CompactionActionType::SHOW_INFO) {
402
0
        std::string json_result;
403
0
        Status st = _handle_show_compaction(req, &json_result);
404
0
        if (!st.ok()) {
405
0
            HttpChannel::send_reply(req, HttpStatus::OK, st.to_json());
406
0
        } else {
407
0
            HttpChannel::send_reply(req, HttpStatus::OK, json_result);
408
0
        }
409
0
    } else if (_compaction_type == CompactionActionType::RUN_COMPACTION) {
410
0
        std::string json_result;
411
0
        Status st = _handle_run_compaction(req, &json_result);
412
0
        if (!st.ok()) {
413
0
            HttpChannel::send_reply(req, HttpStatus::OK, st.to_json());
414
0
        } else {
415
0
            HttpChannel::send_reply(req, HttpStatus::OK, json_result);
416
0
        }
417
0
    } else {
418
0
        std::string json_result;
419
0
        Status st = _handle_run_status_compaction(req, &json_result);
420
0
        if (!st.ok()) {
421
0
            HttpChannel::send_reply(req, HttpStatus::OK, st.to_json());
422
0
        } else {
423
0
            HttpChannel::send_reply(req, HttpStatus::OK, json_result);
424
0
        }
425
0
    }
426
0
}
427
428
} // end namespace doris