Coverage Report

Created: 2026-08-06 19:50

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
be/src/exec/spill/spill_file_writer.cpp
Line
Count
Source
1
// Licensed to the Apache Software Foundation (ASF) under one
2
// or more contributor license agreements.  See the NOTICE file
3
// distributed with this work for additional information
4
// regarding copyright ownership.  The ASF licenses this file
5
// to you under the Apache License, Version 2.0 (the
6
// "License"); you may not use this file except in compliance
7
// with the License.  You may obtain a copy of the License at
8
//
9
//   http://www.apache.org/licenses/LICENSE-2.0
10
//
11
// Unless required by applicable law or agreed to in writing,
12
// software distributed under the License is distributed on an
13
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
14
// KIND, either express or implied.  See the License for the
15
// specific language governing permissions and limitations
16
// under the License.
17
18
#include "exec/spill/spill_file_writer.h"
19
20
#include "agent/be_exec_version_manager.h"
21
#include "common/config.h"
22
#include "common/status.h"
23
#include "exec/spill/spill_file.h"
24
#include "exec/spill/spill_file_manager.h"
25
#include "io/fs/local_file_system.h"
26
#include "io/fs/local_file_writer.h"
27
#include "runtime/exec_env.h"
28
#include "runtime/query_context.h"
29
#include "runtime/runtime_state.h"
30
#include "runtime/thread_context.h"
31
32
namespace doris {
33
34
SpillFileWriter::SpillFileWriter(const std::shared_ptr<SpillFile>& spill_file, RuntimeState* state,
35
                                 RuntimeProfile* profile, SpillDataDir* data_dir,
36
                                 const std::string& spill_dir)
37
308
        : _spill_file_wptr(spill_file),
38
308
          _data_dir(data_dir),
39
308
          _spill_dir(spill_dir),
40
308
          _max_part_size(config::spill_file_part_size_bytes),
41
308
          _resource_ctx(state->get_query_ctx()->resource_ctx()) {
42
    // Common counters
43
308
    RuntimeProfile* common_profile = profile->get_child("CommonCounters");
44
308
    DCHECK(common_profile != nullptr);
45
308
    _memory_used_counter = common_profile->get_counter("MemoryUsage");
46
47
    // Register this writer as the active writer for the SpillFile.
48
308
    spill_file->_active_writer = this;
49
50
    // Custom (spill-specific) counters
51
308
    RuntimeProfile* custom_profile = profile->get_child("CustomCounters");
52
308
    _write_file_timer = custom_profile->get_counter("SpillWriteFileTime");
53
308
    _serialize_timer = custom_profile->get_counter("SpillWriteSerializeBlockTime");
54
308
    _write_block_counter = custom_profile->get_counter("SpillWriteBlockCount");
55
308
    _write_block_bytes_counter = custom_profile->get_counter("SpillWriteBlockBytes");
56
308
    _write_file_total_size = custom_profile->get_counter("SpillWriteFileBytes");
57
308
    _write_file_current_size = custom_profile->get_counter("SpillWriteFileCurrentBytes");
58
308
    _write_rows_counter = custom_profile->get_counter("SpillWriteRows");
59
308
    _total_file_count = custom_profile->get_counter("SpillWriteFileTotalCount");
60
308
}
61
62
308
SpillFileWriter::~SpillFileWriter() {
63
308
    if (_closed) {
64
281
        return;
65
281
    }
66
27
    Status st = close();
67
27
    if (!st.ok()) {
68
15
        LOG(WARNING) << "SpillFileWriter::~SpillFileWriter() failed: " << st.to_string()
69
15
                     << ", spill_dir=" << _spill_dir;
70
15
    }
71
27
}
72
73
271
Status SpillFileWriter::_open_next_part() {
74
271
    _current_part_path = _spill_dir + "/" + std::to_string(_current_part_index);
75
    // Create the spill directory lazily on first part
76
271
    if (_current_part_index == 0) {
77
261
        RETURN_IF_ERROR(io::global_local_filesystem()->create_directory(_spill_dir));
78
261
    }
79
271
    RETURN_IF_ERROR(io::global_local_filesystem()->create_file(_current_part_path, &_file_writer));
80
271
    COUNTER_UPDATE(_total_file_count, 1);
81
271
    return Status::OK();
82
271
}
83
84
317
Status SpillFileWriter::_close_current_part(const std::shared_ptr<SpillFile>& spill_file) {
85
317
    if (!_file_writer) {
86
46
        return Status::OK();
87
46
    }
88
89
    // Write footer: block offsets + max_sub_block_size + block_count
90
271
    _part_meta.append((const char*)&_part_max_sub_block_size, sizeof(_part_max_sub_block_size));
91
271
    _part_meta.append((const char*)&_part_written_blocks, sizeof(_part_written_blocks));
92
93
271
    {
94
271
        SCOPED_TIMER(_write_file_timer);
95
271
        RETURN_IF_ERROR(_file_writer->append(_part_meta));
96
271
    }
97
98
271
    int64_t meta_size = _part_meta.size();
99
271
    _part_written_bytes += meta_size;
100
271
    COUNTER_UPDATE(_write_file_total_size, meta_size);
101
271
    if (_resource_ctx) {
102
271
        _resource_ctx->io_context()->update_spill_write_bytes_to_local_storage(meta_size);
103
271
    }
104
271
    if (_write_file_current_size) {
105
191
        COUNTER_UPDATE(_write_file_current_size, meta_size);
106
191
    }
107
271
    _data_dir->update_spill_data_usage(meta_size);
108
271
    ExecEnv::GetInstance()->spill_file_mgr()->update_spill_write_bytes(meta_size);
109
    // Incrementally update SpillFile's accounting so gc() can always
110
    // decrement the correct amount, even if close() is never called.
111
271
    if (spill_file) {
112
256
        spill_file->update_written_bytes(meta_size);
113
256
    }
114
115
271
    RETURN_IF_ERROR(_file_writer->close());
116
256
    _file_writer.reset();
117
118
    // Advance to next part
119
256
    ++_current_part_index;
120
256
    if (spill_file) {
121
256
        spill_file->increment_part_count();
122
256
    }
123
256
    _part_written_blocks = 0;
124
256
    _part_written_bytes = 0;
125
256
    _part_max_sub_block_size = 0;
126
256
    _part_meta.clear();
127
128
256
    return Status::OK();
129
271
}
130
131
470
Status SpillFileWriter::_rotate_if_needed(const std::shared_ptr<SpillFile>& spill_file) {
132
470
    if (_file_writer && _part_written_bytes >= _max_part_size) {
133
10
        RETURN_IF_ERROR(_close_current_part(spill_file));
134
10
    }
135
470
    return Status::OK();
136
470
}
137
138
473
Status SpillFileWriter::write_block(RuntimeState* state, const Block& block) {
139
473
    DCHECK(!_closed);
140
141
    // Lock the SpillFile to ensure it is still alive. If it has already been
142
    // destroyed (gc'd), we must not write any more data because the disk
143
    // accounting would be out of sync.
144
473
    auto spill_file = _spill_file_wptr.lock();
145
473
    if (!spill_file) {
146
0
        return Status::Error<INTERNAL_ERROR>(
147
0
                "SpillFile has been destroyed, cannot write more data, spill_dir={}", _spill_dir);
148
0
    }
149
150
    // Lazily open the first part
151
473
    if (!_file_writer) {
152
271
        if (_current_part_index == 0) {
153
261
            state->get_query_ctx()->record_spill_data_dir(_data_dir);
154
261
        }
155
271
        RETURN_IF_ERROR(_open_next_part());
156
271
    }
157
158
473
    DBUG_EXECUTE_IF("fault_inject::spill_file::spill_block", {
159
473
        return Status::Error<INTERNAL_ERROR>("fault_inject spill_file spill_block failed");
160
473
    });
161
162
470
    auto rows = block.rows();
163
470
    COUNTER_UPDATE(_write_rows_counter, rows);
164
470
    COUNTER_UPDATE(_write_block_bytes_counter, block.bytes());
165
166
470
    RETURN_IF_ERROR(_write_internal(block, spill_file));
167
168
    // Auto-rotate if current part is full
169
470
    return _rotate_if_needed(spill_file);
170
470
}
171
172
326
Status SpillFileWriter::close() {
173
326
    if (_closed) {
174
18
        return Status::OK();
175
18
    }
176
308
    _closed = true;
177
178
308
    DBUG_EXECUTE_IF("fault_inject::spill_file::spill_eof", {
179
308
        return Status::Error<INTERNAL_ERROR>("fault_inject spill_file spill_eof failed");
180
308
    });
181
182
307
    auto spill_file = _spill_file_wptr.lock();
183
307
    RETURN_IF_ERROR(_close_current_part(spill_file));
184
185
292
    if (spill_file) {
186
292
        if (spill_file->_active_writer != this) {
187
0
            return Status::Error<INTERNAL_ERROR>(
188
0
                    "SpillFileWriter close() called but not registered as active writer, possible "
189
0
                    "double close or logic error");
190
0
        }
191
292
        spill_file->finish_writing();
192
292
    }
193
194
292
    return Status::OK();
195
292
}
196
197
Status SpillFileWriter::_write_internal(const Block& block,
198
470
                                        const std::shared_ptr<SpillFile>& spill_file) {
199
470
    size_t uncompressed_bytes = 0, compressed_bytes = 0;
200
201
470
    Status status;
202
470
    std::string buff;
203
470
    int64_t buff_size {0};
204
205
470
    if (block.rows() > 0) {
206
453
        {
207
453
            PBlock pblock;
208
453
            SCOPED_TIMER(_serialize_timer);
209
453
            int64_t compressed_time = 0;
210
453
            status = block.serialize(
211
453
                    BeExecVersionManager::get_newest_version(), &pblock, &uncompressed_bytes,
212
453
                    &compressed_bytes, &compressed_time,
213
453
                    segment_v2::CompressionTypePB::ZSTD); // ZSTD for better compression ratio
214
453
            RETURN_IF_ERROR(status);
215
453
            int64_t pblock_mem = pblock.ByteSizeLong();
216
453
            COUNTER_UPDATE(_memory_used_counter, pblock_mem);
217
453
            Defer defer {[&]() { COUNTER_UPDATE(_memory_used_counter, -pblock_mem); }};
218
453
            if (!pblock.SerializeToString(&buff)) {
219
0
                return Status::Error<ErrorCode::SERIALIZE_PROTOBUF_ERROR>(
220
0
                        "serialize spill data error. [path={}]", _current_part_path);
221
0
            }
222
453
            buff_size = buff.size();
223
453
            COUNTER_UPDATE(_memory_used_counter, buff_size);
224
453
            Defer defer2 {[&]() { COUNTER_UPDATE(_memory_used_counter, -buff_size); }};
225
453
        }
226
453
        if (_data_dir->reach_capacity_limit(buff_size)) {
227
0
            return Status::Error<ErrorCode::DISK_REACH_CAPACITY_LIMIT>(
228
0
                    "spill data total size exceed limit, path: {}, size limit: {}, spill data "
229
0
                    "size: {}",
230
0
                    _data_dir->path(),
231
0
                    PrettyPrinter::print_bytes(_data_dir->get_spill_data_limit()),
232
0
                    PrettyPrinter::print_bytes(_data_dir->get_spill_data_bytes()));
233
0
        }
234
235
453
        {
236
453
            Defer defer {[&]() {
237
453
                if (status.ok()) {
238
453
                    _data_dir->update_spill_data_usage(buff_size);
239
453
                    ExecEnv::GetInstance()->spill_file_mgr()->update_spill_write_bytes(buff_size);
240
241
453
                    _part_max_sub_block_size =
242
453
                            std::max(_part_max_sub_block_size, (size_t)buff_size);
243
244
453
                    _part_meta.append((const char*)&_part_written_bytes, sizeof(size_t));
245
453
                    COUNTER_UPDATE(_write_file_total_size, buff_size);
246
453
                    if (_resource_ctx) {
247
453
                        _resource_ctx->io_context()->update_spill_write_bytes_to_local_storage(
248
453
                                buff_size);
249
453
                    }
250
453
                    if (_write_file_current_size) {
251
325
                        COUNTER_UPDATE(_write_file_current_size, buff_size);
252
325
                    }
253
453
                    COUNTER_UPDATE(_write_block_counter, 1);
254
453
                    _part_written_bytes += buff_size;
255
453
                    ++_part_written_blocks;
256
                    // Incrementally update SpillFile so gc() can always
257
                    // decrement the correct amount from _data_dir.
258
453
                    spill_file->update_written_bytes(buff_size);
259
453
                }
260
453
            }};
261
453
            {
262
453
                SCOPED_TIMER(_write_file_timer);
263
453
                status = _file_writer->append(buff);
264
453
                RETURN_IF_ERROR(status);
265
453
            }
266
453
        }
267
453
    }
268
269
470
    return status;
270
470
}
271
272
} // namespace doris