be/src/util/blocking_queue.hpp

Source
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements.  See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership.  The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License.  You may obtain a copy of the License at
//
//   http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied.  See the License for the
// specific language governing permissions and limitations
// under the License.
// This file is copied from
// https://github.com/apache/impala/blob/branch-2.9.0/be/src/util/blocking-queue.hpp
// and modified by Doris

#pragma once

#include <unistd.h>

#include <atomic>
#include <condition_variable>
#include <list>
#include <mutex>

#include "common/logging.h"
#include "util/stopwatch.hpp"

#ifdef BE_TEST
#include "cpp/sync_point.h"
#endif

namespace doris {
// Fixed capacity FIFO queue, where both BlockingGet and BlockingPut operations block
// if the queue is empty or full, respectively.
template <typename T>
class BlockingQueue {
public:
    BlockingQueue(uint32_t max_elements)
            : _shutdown(false),
              _max_elements(max_elements),
              _total_get_wait_time(0),
              _total_put_wait_time(0),
              _get_waiting(0),
              _put_waiting(0) {}

    // Get an element from the queue, waiting indefinitely for one to become available.
    // Returns false if we were shut down prior to getting the element, and there
    // are no more elements available.
    bool blocking_get(T* out) { return controlled_blocking_get(out, MAX_CV_WAIT_TIMEOUT_MS); }

    // Blocking_get and blocking_put may cause deadlock,
    // but we still don't find root cause,
    // introduce condition variable wait timeout to avoid blocking queue deadlock temporarily.
    bool controlled_blocking_get(T* out, int64_t cv_wait_timeout_ms) {
        MonotonicStopWatch timer;
        timer.start();
        std::unique_lock<std::mutex> unique_lock(_lock);
#ifdef BE_TEST
        TEST_SYNC_POINT("BlockingQueue::controlled_blocking_get::after_lock");
#endif
        while (!(_shutdown || !_list.empty())) {
            ++_get_waiting;
#ifdef BE_TEST
            TEST_SYNC_POINT("BlockingQueue::controlled_blocking_get::before_wait");
#endif
            _get_cv.wait_for(unique_lock, std::chrono::milliseconds(cv_wait_timeout_ms));
            DCHECK_GT(_get_waiting, 0);
            --_get_waiting;
        }
        _total_get_wait_time += timer.elapsed_time();

        if (!_list.empty()) {
            *out = _list.front();
            _list.pop_front();
            const bool has_put_waiter = _put_waiting > 0;
            unique_lock.unlock();
            if (has_put_waiter) {
                _put_cv.notify_one();
            }
            return true;
        } else {
            assert(_shutdown);
            return false;
        }
    }

    // Puts an element into the queue, waiting indefinitely until there is space.
    // If the queue is shut down, returns false.
    bool blocking_put(const T& val) { return controlled_blocking_put(val, MAX_CV_WAIT_TIMEOUT_MS); }

    // Blocking_get and blocking_put may cause deadlock,
    // but we still don't find root cause,
    // introduce condition variable wait timeout to avoid blocking queue deadlock temporarily.
    bool controlled_blocking_put(const T& val, int64_t cv_wait_timeout_ms) {
        MonotonicStopWatch timer;
        timer.start();
        std::unique_lock<std::mutex> unique_lock(_lock);
        while (!(_shutdown || _list.size() < _max_elements)) {
            ++_put_waiting;
#ifdef BE_TEST
            TEST_SYNC_POINT("BlockingQueue::controlled_blocking_put::before_wait");
#endif
            _put_cv.wait_for(unique_lock, std::chrono::milliseconds(cv_wait_timeout_ms));
            DCHECK_GT(_put_waiting, 0);
            --_put_waiting;
        }
        _total_put_wait_time += timer.elapsed_time();

        if (_shutdown) {
            return false;
        }

        _list.push_back(val);
        const bool has_get_waiter = _get_waiting > 0;
        unique_lock.unlock();
        if (has_get_waiter) {
            _get_cv.notify_one();
        }
        return true;
    }

    // Return false if queue full or has been shutdown.
    bool try_put(const T& val) {
        MonotonicStopWatch timer;
        timer.start();
        std::unique_lock<std::mutex> unique_lock(_lock);
#ifdef BE_TEST
        TEST_SYNC_POINT("BlockingQueue::try_put::after_lock");
#endif
        _total_put_wait_time += timer.elapsed_time();

        if (_shutdown || _list.size() >= _max_elements) {
            return false;
        }

        _list.push_back(val);
        const bool has_get_waiter = _get_waiting > 0;
        unique_lock.unlock();
        if (has_get_waiter) {
            _get_cv.notify_one();
        }
        return true;
    }

    // Shut down the queue. Wakes up all threads waiting on BlockingGet or BlockingPut.
    void shutdown() {
        {
            std::lock_guard<std::mutex> guard(_lock);
            _shutdown = true;
        }

        _get_cv.notify_all();
        _put_cv.notify_all();
    }

    uint32_t get_size() const {
        std::lock_guard<std::mutex> l(_lock);
        return static_cast<uint32_t>(_list.size());
    }

    uint32_t get_capacity() const { return _max_elements; }

#ifdef BE_TEST
    size_t get_waiting_count_for_test() const {
        std::lock_guard<std::mutex> guard(_lock);
        return _get_waiting;
    }

    size_t put_waiting_count_for_test() const {
        std::lock_guard<std::mutex> guard(_lock);
        return _put_waiting;
    }
#endif

    // Returns the total amount of time threads have blocked in BlockingGet.
    uint64_t total_get_wait_time() const { return _total_get_wait_time; }

    // Returns the total amount of time threads have blocked in BlockingPut.
    uint64_t total_put_wait_time() const { return _total_put_wait_time; }

private:
    static constexpr int64_t MAX_CV_WAIT_TIMEOUT_MS = 60 * 60 * 1000; // 1 hour
    bool _shutdown;
    const int _max_elements;
    std::condition_variable _get_cv; // 'get' callers wait on this
    std::condition_variable _put_cv; // 'put' callers wait on this
    // _lock guards access to _shutdown, _get_waiting, _put_waiting, _list, total_get_wait_time, and total_put_wait_time
    mutable std::mutex _lock;
    std::list<T> _list;
    std::atomic<uint64_t> _total_get_wait_time;
    std::atomic<uint64_t> _total_put_wait_time;
    // Number of threads currently inside the corresponding wait_for() call. The waiter that
    // increments a counter is also responsible for decrementing it after every wakeup reason.
    // Notifiers only inspect these counters and never consume a waiter's registration.
    size_t _get_waiting;
    size_t _put_waiting;
};
} // namespace doris

Coverage Report

Created: 2026-07-23 18:52