Coverage Report

Created: 2025-06-08 11:30

/root/doris/be/src/olap/rowset/segcompaction.cpp
Line
Count
Source (jump to first uncovered line)
1
// Licensed to the Apache Software Foundation (ASF) under one
2
// or more contributor license agreements.  See the NOTICE file
3
// distributed with this work for additional information
4
// regarding copyright ownership.  The ASF licenses this file
5
// to you under the Apache License, Version 2.0 (the
6
// "License"); you may not use this file except in compliance
7
// with the License.  You may obtain a copy of the License at
8
//
9
//   http://www.apache.org/licenses/LICENSE-2.0
10
//
11
// Unless required by applicable law or agreed to in writing,
12
// software distributed under the License is distributed on an
13
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
14
// KIND, either express or implied.  See the License for the
15
// specific language governing permissions and limitations
16
// under the License.
17
18
#include "segcompaction.h"
19
20
#include <fmt/format.h>
21
#include <gen_cpp/olap_file.pb.h>
22
#include <limits.h>
23
24
#include <algorithm>
25
#include <atomic>
26
#include <condition_variable>
27
#include <filesystem>
28
#include <map>
29
#include <memory>
30
#include <mutex>
31
#include <sstream>
32
#include <string>
33
#include <utility>
34
35
#include "beta_rowset_writer.h"
36
#include "common/compiler_util.h" // IWYU pragma: keep
37
#include "common/logging.h"
38
#include "gutil/stringprintf.h"
39
#include "gutil/strings/substitute.h"
40
#include "io/fs/file_system.h"
41
#include "io/fs/file_writer.h"
42
#include "io/io_common.h"
43
#include "olap/data_dir.h"
44
#include "olap/iterators.h"
45
#include "olap/merger.h"
46
#include "olap/olap_common.h"
47
#include "olap/olap_define.h"
48
#include "olap/rowset/beta_rowset.h"
49
#include "olap/rowset/rowset_meta.h"
50
#include "olap/rowset/rowset_writer_context.h"
51
#include "olap/rowset/segment_v2/inverted_index_cache.h"
52
#include "olap/rowset/segment_v2/inverted_index_desc.h"
53
#include "olap/rowset/segment_v2/segment.h"
54
#include "olap/rowset/segment_v2/segment_writer.h"
55
#include "olap/schema.h"
56
#include "olap/storage_engine.h"
57
#include "olap/tablet_reader.h"
58
#include "olap/tablet_schema.h"
59
#include "runtime/memory/global_memory_arbitrator.h"
60
#include "runtime/thread_context.h"
61
#include "util/debug_points.h"
62
#include "util/mem_info.h"
63
#include "util/time.h"
64
#include "vec/olap/vertical_block_reader.h"
65
#include "vec/olap/vertical_merge_iterator.h"
66
67
namespace doris {
68
using namespace ErrorCode;
69
70
705
SegcompactionWorker::SegcompactionWorker(BetaRowsetWriter* writer) : _writer(writer) {}
71
72
705
void SegcompactionWorker::init_mem_tracker(int64_t txn_id) {
73
705
    _seg_compact_mem_tracker = MemTrackerLimiter::create_shared(
74
705
            MemTrackerLimiter::Type::COMPACTION, "segcompaction-" + std::to_string(txn_id));
75
705
}
76
77
Status SegcompactionWorker::_get_segcompaction_reader(
78
        SegCompactionCandidatesSharedPtr segments, TabletSharedPtr tablet,
79
        std::shared_ptr<Schema> schema, OlapReaderStatistics* stat,
80
        vectorized::RowSourcesBuffer& row_sources_buf, bool is_key,
81
        std::vector<uint32_t>& return_columns,
82
22
        std::unique_ptr<vectorized::VerticalBlockReader>* reader) {
83
22
    auto ctx = _writer->_context;
84
22
    bool record_rowids = need_convert_delete_bitmap() && is_key;
85
22
    StorageReadOptions read_options;
86
22
    read_options.stats = stat;
87
22
    read_options.use_page_cache = false;
88
22
    read_options.tablet_schema = ctx.tablet_schema;
89
22
    read_options.record_rowids = record_rowids;
90
22
    std::vector<std::unique_ptr<RowwiseIterator>> seg_iterators;
91
22
    std::map<uint32_t, uint32_t> segment_rows;
92
118
    for (auto& seg_ptr : *segments) {
93
118
        std::unique_ptr<RowwiseIterator> iter;
94
118
        auto s = seg_ptr->new_iterator(schema, read_options, &iter);
95
118
        if (!s.ok()) {
96
0
            return Status::Error<INIT_FAILED>("failed to create iterator[{}]: {}", seg_ptr->id(),
97
0
                                              s.to_string());
98
0
        }
99
118
        seg_iterators.push_back(std::move(iter));
100
118
        segment_rows.emplace(seg_ptr->id(), seg_ptr->num_rows());
101
118
    }
102
22
    if (record_rowids && _rowid_conversion != nullptr) {
103
4
        _rowid_conversion->reset_segment_map(segment_rows);
104
4
    }
105
106
22
    *reader = std::unique_ptr<vectorized::VerticalBlockReader> {
107
22
            new vectorized::VerticalBlockReader(&row_sources_buf)};
108
109
22
    TabletReader::ReaderParams reader_params;
110
22
    reader_params.is_segcompaction = true;
111
22
    reader_params.segment_iters_ptr = &seg_iterators;
112
    // no reader_params.version shouldn't break segcompaction
113
22
    reader_params.tablet_schema = ctx.tablet_schema;
114
22
    reader_params.tablet = tablet;
115
22
    reader_params.return_columns = return_columns;
116
22
    reader_params.is_key_column_group = is_key;
117
22
    reader_params.use_page_cache = false;
118
22
    reader_params.record_rowids = record_rowids;
119
22
    return (*reader)->init(reader_params, nullptr);
120
22
}
121
122
std::unique_ptr<segment_v2::SegmentWriter> SegcompactionWorker::_create_segcompaction_writer(
123
11
        uint32_t begin, uint32_t end) {
124
11
    Status status;
125
11
    std::unique_ptr<segment_v2::SegmentWriter> writer = nullptr;
126
11
    status = _create_segment_writer_for_segcompaction(&writer, begin, end);
127
11
    if (!status.ok() || writer == nullptr) {
128
0
        LOG(ERROR) << "failed to create segment writer for begin:" << begin << " end:" << end
129
0
                   << " status:" << status;
130
0
        return nullptr;
131
11
    } else {
132
11
        return writer;
133
11
    }
134
11
}
135
136
11
Status SegcompactionWorker::_delete_original_segments(uint32_t begin, uint32_t end) {
137
11
    auto fs = _writer->_rowset_meta->fs();
138
11
    auto ctx = _writer->_context;
139
11
    auto schema = ctx.tablet_schema;
140
11
    if (!fs) {
141
0
        return Status::Error<INIT_FAILED>(
142
0
                "SegcompactionWorker::_delete_original_segments get fs failed");
143
0
    }
144
70
    for (uint32_t i = begin; i <= end; ++i) {
145
59
        auto seg_path = BetaRowset::segment_file_path(ctx.rowset_dir, ctx.rowset_id, i);
146
        // Even if an error is encountered, these files that have not been cleaned up
147
        // will be cleaned up by the GC background. So here we only print the error
148
        // message when we encounter an error.
149
59
        RETURN_NOT_OK_STATUS_WITH_WARN(fs->delete_file(seg_path),
150
59
                                       strings::Substitute("Failed to delete file=$0", seg_path));
151
59
        if (schema->has_inverted_index() &&
152
59
            schema->get_inverted_index_storage_format() != InvertedIndexStorageFormatPB::V1) {
153
0
            auto idx_path = InvertedIndexDescriptor::get_index_file_name(seg_path);
154
0
            VLOG_DEBUG << "segcompaction index. delete file " << idx_path;
155
0
            RETURN_NOT_OK_STATUS_WITH_WARN(
156
0
                    fs->delete_file(idx_path),
157
0
                    strings::Substitute("Failed to delete file=$0", idx_path));
158
0
        }
159
        // Delete inverted index files
160
207
        for (auto column : schema->columns()) {
161
207
            if (schema->has_inverted_index(*column)) {
162
0
                auto index_info = schema->get_inverted_index(*column);
163
0
                auto index_id = index_info->index_id();
164
0
                auto idx_path = InvertedIndexDescriptor::inverted_index_file_path(
165
0
                        ctx.rowset_dir, ctx.rowset_id, i, index_id, index_info->get_index_suffix());
166
0
                VLOG_DEBUG << "segcompaction index. delete file " << idx_path;
167
0
                if (schema->get_inverted_index_storage_format() ==
168
0
                    InvertedIndexStorageFormatPB::V1) {
169
0
                    RETURN_NOT_OK_STATUS_WITH_WARN(
170
0
                            fs->delete_file(idx_path),
171
0
                            strings::Substitute("Failed to delete file=$0", idx_path));
172
0
                }
173
                // Erase the origin index file cache
174
0
                RETURN_IF_ERROR(InvertedIndexSearcherCache::instance()->erase(idx_path));
175
0
            }
176
207
        }
177
59
    }
178
11
    return Status::OK();
179
11
}
180
181
Status SegcompactionWorker::_check_correctness(OlapReaderStatistics& reader_stat,
182
                                               Merger::Statistics& merger_stat, uint32_t begin,
183
11
                                               uint32_t end) {
184
11
    uint64_t raw_rows_read = reader_stat.raw_rows_read; /* total rows read before merge */
185
11
    uint64_t sum_src_row = 0; /* sum of rows in each involved source segments */
186
11
    uint64_t filtered_rows = merger_stat.filtered_rows; /* rows filtered by del conditions */
187
11
    uint64_t output_rows = merger_stat.output_rows;     /* rows after merge */
188
11
    uint64_t merged_rows = merger_stat.merged_rows;     /* dup key merged by unique/agg */
189
190
11
    {
191
11
        std::lock_guard<std::mutex> lock(_writer->_segid_statistics_map_mutex);
192
70
        for (int i = begin; i <= end; ++i) {
193
59
            sum_src_row += _writer->_segid_statistics_map[i].row_num;
194
59
        }
195
11
    }
196
197
11
    DBUG_EXECUTE_IF("SegcompactionWorker._check_correctness_wrong_sum_src_row", { sum_src_row++; });
198
11
    if (raw_rows_read != sum_src_row) {
199
0
        return Status::Error<CHECK_LINES_ERROR>(
200
0
                "segcompaction read row num does not match source. expect read row:{}, actual read "
201
0
                "row:{}",
202
0
                sum_src_row, raw_rows_read);
203
0
    }
204
205
11
    DBUG_EXECUTE_IF("SegcompactionWorker._check_correctness_wrong_merged_rows", { merged_rows++; });
206
11
    if ((output_rows + merged_rows) != raw_rows_read) {
207
0
        return Status::Error<CHECK_LINES_ERROR>(
208
0
                "segcompaction total row num does not match after merge. expect total row:{},  "
209
0
                "actual total row:{}, (output_rows:{},merged_rows:{})",
210
0
                raw_rows_read, output_rows + merged_rows, output_rows, merged_rows);
211
0
    }
212
11
    DBUG_EXECUTE_IF("SegcompactionWorker._check_correctness_wrong_filtered_rows",
213
11
                    { filtered_rows++; });
214
11
    if (filtered_rows != 0) {
215
0
        return Status::Error<CHECK_LINES_ERROR>(
216
0
                "segcompaction should not have filtered rows but actual filtered rows:{}",
217
0
                filtered_rows);
218
0
    }
219
11
    return Status::OK();
220
11
}
221
222
Status SegcompactionWorker::_create_segment_writer_for_segcompaction(
223
11
        std::unique_ptr<segment_v2::SegmentWriter>* writer, uint32_t begin, uint32_t end) {
224
11
    return _writer->_create_segment_writer_for_segcompaction(writer, begin, end);
225
11
}
226
227
11
Status SegcompactionWorker::_do_compact_segments(SegCompactionCandidatesSharedPtr segments) {
228
11
    DCHECK(_seg_compact_mem_tracker != nullptr);
229
11
    SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER(_seg_compact_mem_tracker);
230
    /* throttle segcompaction task if memory depleted */
231
11
    if (GlobalMemoryArbitrator::is_exceed_soft_mem_limit(GB_EXCHANGE_BYTE)) {
232
0
        return Status::Error<FETCH_MEMORY_EXCEEDED>("skip segcompaction due to memory shortage");
233
0
    }
234
235
11
    uint32_t begin = (*(segments->begin()))->id();
236
11
    uint32_t end = (*(segments->end() - 1))->id();
237
11
    uint64_t begin_time = GetCurrentTimeMicros();
238
11
    uint64_t index_size = 0;
239
11
    uint64_t total_index_size = 0;
240
11
    auto ctx = _writer->_context;
241
242
11
    auto writer = _create_segcompaction_writer(begin, end);
243
11
    if (UNLIKELY(writer == nullptr)) {
244
0
        return Status::Error<SEGCOMPACTION_INIT_WRITER>("failed to get segcompaction writer");
245
0
    }
246
247
11
    DCHECK(ctx.tablet);
248
11
    auto tablet = std::static_pointer_cast<Tablet>(ctx.tablet);
249
11
    if (need_convert_delete_bitmap() && _rowid_conversion == nullptr) {
250
3
        _rowid_conversion = std::make_unique<SimpleRowIdConversion>(_writer->rowset_id());
251
3
    }
252
253
11
    std::vector<std::vector<uint32_t>> column_groups;
254
11
    Merger::vertical_split_columns(ctx.tablet_schema, &column_groups);
255
11
    vectorized::RowSourcesBuffer row_sources_buf(tablet->tablet_id(), tablet->tablet_path(),
256
11
                                                 ReaderType::READER_SEGMENT_COMPACTION);
257
258
11
    KeyBoundsPB key_bounds;
259
11
    Merger::Statistics key_merger_stats;
260
11
    OlapReaderStatistics key_reader_stats;
261
    /* compact group one by one */
262
33
    for (auto i = 0; i < column_groups.size(); ++i) {
263
22
        VLOG_NOTICE << "row source size: " << row_sources_buf.total_size();
264
22
        bool is_key = (i == 0);
265
22
        std::vector<uint32_t> column_ids = column_groups[i];
266
267
22
        writer->clear();
268
22
        RETURN_IF_ERROR(writer->init(column_ids, is_key));
269
22
        auto schema = std::make_shared<Schema>(ctx.tablet_schema->columns(), column_ids);
270
22
        OlapReaderStatistics reader_stats;
271
22
        std::unique_ptr<vectorized::VerticalBlockReader> reader;
272
22
        auto s = _get_segcompaction_reader(segments, tablet, schema, &reader_stats, row_sources_buf,
273
22
                                           is_key, column_ids, &reader);
274
22
        if (UNLIKELY(reader == nullptr || !s.ok())) {
275
0
            return Status::Error<SEGCOMPACTION_INIT_READER>(
276
0
                    "failed to get segcompaction reader. err: {}", s.to_string());
277
0
        }
278
279
22
        Merger::Statistics merger_stats;
280
22
        RETURN_IF_ERROR(Merger::vertical_compact_one_group(
281
22
                tablet, ReaderType::READER_SEGMENT_COMPACTION, ctx.tablet_schema, is_key,
282
22
                column_ids, &row_sources_buf, *reader, *writer, &merger_stats, &index_size,
283
22
                key_bounds, _rowid_conversion.get()));
284
22
        total_index_size += index_size;
285
22
        if (is_key) {
286
11
            RETURN_IF_ERROR(row_sources_buf.flush());
287
11
            key_merger_stats = merger_stats;
288
11
            key_reader_stats = reader_stats;
289
11
        }
290
22
        RETURN_IF_ERROR(row_sources_buf.seek_to_begin());
291
22
    }
292
293
    /* check row num after merge/aggregation */
294
11
    RETURN_NOT_OK_STATUS_WITH_WARN(
295
11
            _check_correctness(key_reader_stats, key_merger_stats, begin, end),
296
11
            "check correctness failed");
297
11
    {
298
11
        std::lock_guard<std::mutex> lock(_writer->_segid_statistics_map_mutex);
299
11
        _writer->_clear_statistics_for_deleting_segments_unsafe(begin, end);
300
11
    }
301
11
    RETURN_IF_ERROR(
302
11
            _writer->flush_segment_writer_for_segcompaction(&writer, total_index_size, key_bounds));
303
304
11
    if (_file_writer != nullptr) {
305
11
        RETURN_IF_ERROR(_file_writer->close());
306
11
    }
307
308
11
    RETURN_IF_ERROR(_delete_original_segments(begin, end));
309
11
    if (_rowid_conversion != nullptr) {
310
4
        convert_segment_delete_bitmap(ctx.mow_context->delete_bitmap, begin, end,
311
4
                                      _writer->_num_segcompacted);
312
4
    }
313
11
    RETURN_IF_ERROR(_writer->_rename_compacted_segments(begin, end));
314
315
11
    if (VLOG_DEBUG_IS_ON) {
316
0
        _writer->vlog_buffer.clear();
317
0
        for (const auto& entry : std::filesystem::directory_iterator(ctx.rowset_dir)) {
318
0
            fmt::format_to(_writer->vlog_buffer, "[{}]", string(entry.path()));
319
0
        }
320
0
        VLOG_DEBUG << "tablet_id:" << ctx.tablet_id << " rowset_id:" << ctx.rowset_id
321
0
                   << "_segcompacted_point:" << _writer->_segcompacted_point
322
0
                   << " _num_segment:" << _writer->_num_segment
323
0
                   << " _num_segcompacted:" << _writer->_num_segcompacted
324
0
                   << " list directory:" << fmt::to_string(_writer->vlog_buffer);
325
0
    }
326
327
11
    _writer->_segcompacted_point += (end - begin + 1);
328
329
11
    uint64_t elapsed = GetCurrentTimeMicros() - begin_time;
330
11
    LOG(INFO) << "segcompaction completed. tablet_id:" << ctx.tablet_id
331
11
              << " rowset_id:" << ctx.rowset_id << " elapsed time:" << elapsed
332
11
              << "us. update segcompacted_point:" << _writer->_segcompacted_point
333
11
              << " segment num:" << segments->size() << " begin:" << begin << " end:" << end;
334
335
11
    return Status::OK();
336
11
}
337
338
11
void SegcompactionWorker::compact_segments(SegCompactionCandidatesSharedPtr segments) {
339
11
    Status status = Status::OK();
340
11
    if (_is_compacting_state_mutable.exchange(false)) {
341
11
        status = _do_compact_segments(segments);
342
11
    } else {
343
        // note: be aware that _writer maybe released when the task is cancelled
344
0
        LOG(INFO) << "segcompaction worker is cancelled, skipping segcompaction task";
345
0
        return;
346
0
    }
347
11
    if (!status.ok()) {
348
0
        int16_t errcode = status.code();
349
0
        switch (errcode) {
350
0
        case FETCH_MEMORY_EXCEEDED:
351
0
        case SEGCOMPACTION_INIT_READER:
352
0
        case SEGCOMPACTION_INIT_WRITER:
353
0
            LOG(WARNING) << "segcompaction failed, try next time:" << status;
354
0
            break;
355
0
        default:
356
0
            auto ctx = _writer->_context;
357
0
            LOG(WARNING) << "segcompaction fatal, terminating the write job."
358
0
                         << " tablet_id:" << ctx.tablet_id << " rowset_id:" << ctx.rowset_id
359
0
                         << " status:" << status;
360
            // status will be checked by the next trigger of segcompaction or the final wait
361
0
            _writer->_segcompaction_status.store(ErrorCode::INTERNAL_ERROR);
362
0
        }
363
0
    }
364
11
    DCHECK_EQ(_writer->_is_doing_segcompaction, true);
365
11
    {
366
11
        std::lock_guard lk(_writer->_is_doing_segcompaction_lock);
367
11
        _writer->_is_doing_segcompaction = false;
368
11
        _writer->_segcompacting_cond.notify_all();
369
11
    }
370
11
    _is_compacting_state_mutable = true;
371
11
}
372
373
84
bool SegcompactionWorker::need_convert_delete_bitmap() {
374
84
    if (_writer == nullptr) {
375
0
        return false;
376
0
    }
377
84
    auto tablet = _writer->context().tablet;
378
84
    return tablet != nullptr && tablet->keys_type() == KeysType::UNIQUE_KEYS &&
379
84
           tablet->enable_unique_key_merge_on_write() &&
380
84
           tablet->tablet_schema()->has_sequence_col();
381
84
}
382
383
void SegcompactionWorker::convert_segment_delete_bitmap(DeleteBitmapPtr src_delete_bitmap,
384
22
                                                        uint32_t src_seg_id, uint32_t dest_seg_id) {
385
    // lazy init
386
22
    if (nullptr == _converted_delete_bitmap) {
387
1
        _converted_delete_bitmap = std::make_shared<DeleteBitmap>(_writer->context().tablet_id);
388
1
    }
389
22
    auto rowset_id = _writer->context().rowset_id;
390
22
    const auto* seg_map =
391
22
            src_delete_bitmap->get({rowset_id, src_seg_id, DeleteBitmap::TEMP_VERSION_COMMON});
392
22
    if (seg_map != nullptr) {
393
15
        _converted_delete_bitmap->set({rowset_id, dest_seg_id, DeleteBitmap::TEMP_VERSION_COMMON},
394
15
                                      *seg_map);
395
15
    }
396
22
}
397
398
void SegcompactionWorker::convert_segment_delete_bitmap(DeleteBitmapPtr src_delete_bitmap,
399
                                                        uint32_t src_begin, uint32_t src_end,
400
4
                                                        uint32_t dst_seg_id) {
401
    // lazy init
402
4
    if (nullptr == _converted_delete_bitmap) {
403
3
        _converted_delete_bitmap = std::make_shared<DeleteBitmap>(_writer->context().tablet_id);
404
3
    }
405
4
    auto rowset_id = _writer->context().rowset_id;
406
4
    RowLocation src(rowset_id, 0, 0);
407
34
    for (uint32_t seg_id = src_begin; seg_id <= src_end; seg_id++) {
408
30
        const auto* seg_map =
409
30
                src_delete_bitmap->get({rowset_id, seg_id, DeleteBitmap::TEMP_VERSION_COMMON});
410
30
        if (!seg_map) {
411
6
            continue;
412
6
        }
413
24
        src.segment_id = seg_id;
414
57.3k
        for (unsigned int row_id : *seg_map) {
415
57.3k
            src.row_id = row_id;
416
57.3k
            auto dst_row_id = _rowid_conversion->get(src);
417
57.3k
            if (dst_row_id < 0) {
418
5.27k
                continue;
419
5.27k
            }
420
52.0k
            _converted_delete_bitmap->add(
421
52.0k
                    {rowset_id, dst_seg_id, DeleteBitmap::TEMP_VERSION_COMMON}, dst_row_id);
422
52.0k
        }
423
24
    }
424
4
}
425
426
682
bool SegcompactionWorker::cancel() {
427
    // return true if the task is canncellable (actual compaction is not started)
428
    // return false when the task is not cancellable (it is in the middle of segcompaction)
429
682
    return _is_compacting_state_mutable.exchange(false);
430
682
}
431
432
} // namespace doris